Re: [PATCH] arm64: dts: rockchip: add the power domain node for rk3399

From: Doug Anderson
Date: Thu Jun 30 2016 - 18:40:23 EST


Hi,

On Thu, Jun 30, 2016 at 2:57 PM, Heiko Stuebner <heiko@xxxxxxxxx> wrote:
>> It looks like there are also more power domains that you haven't
>> listed here (like PD_GMAC, for instance, or PD_CORE_L). Are you
>> planning to add those in a followon patch?
>
> that reminds me, nodes with a reg property should have the base address in
> the node name as well. Using the constant works nicely, as can be seen on
> the rk3288 where we have for example:
>
> pd_vio@RK3288_PD_VIO

I was wondering about that. The device tree bindings are similarly
missing the reg from the example.

I'm curious: for sorting purposes, are you supposed to know the
underlying integer and use that for sorting, or sort by the name of
the #define?

-Doug