Re: [PATCH 0/4] ftrace: One more check on x86 and some small fixes

From: Petr Mladek
Date: Wed Jun 29 2016 - 04:22:56 EST


On Tue 2016-06-28 15:17:56, Steven Rostedt wrote:
> On Mon, 27 Jun 2016 15:54:33 +0200
> Petr Mladek <pmladek@xxxxxxxx> wrote:
>
> > 1st patch adds one more paranoid check of the modified function on x86.
> >
> > Plus there are 3 small changes that appeared when hunting down
> > the 1st patch.
> >
> > Petr Mladek (4):
> > ftrace/x86: Make sure to modify 5-bite instructions
> > ftrace/x86: Do not crash when reading wrong ftrace func
>
> The first two are mostly just "detect error, when it happens again"
> chanes.

Yup.

> > ftrace: Always destroy trampoline when shutting down the trace
> > ftrace: Fixup trace_selftest_ops()
>
> These two seem to fix real bugs. I'm thinking they should go in now and
> be backported via stable.
>
> Thoughts?

Makes sense. Should I do anything, please?

Best Regards,
Petr