Re: [PATCH 1/2] MADVISE_FREE, THP: Fix madvise_free_huge_pmd return value after splitting

From: Minchan Kim
Date: Wed Jun 29 2016 - 03:26:03 EST


On Tue, Jun 28, 2016 at 10:36:29AM -0700, Huang, Ying wrote:
> From: Huang Ying <ying.huang@xxxxxxxxx>
>
> madvise_free_huge_pmd should return 0 if the fallback PTE operations are
> required. In madvise_free_huge_pmd, if part pages of THP are discarded,
> the THP will be split and fallback PTE operations should be used if
> splitting succeeds. But the original code will make fallback PTE
> operations skipped, after splitting succeeds. Fix that via make
> madvise_free_huge_pmd return 0 after splitting successfully, so that the
> fallback PTE operations will be done.
>
> Cc: Minchan Kim <minchan@xxxxxxxxxx>
> Signed-off-by: "Huang, Ying" <ying.huang@xxxxxxxxx>
Acked-by: Minchan Kim <minchan@xxxxxxxxxx>

Thanks!