Re: [PATCH v2] clk: fixed-factor: add optional dt-binding clock-flags

From: Michael Turquette
Date: Tue Jun 28 2016 - 17:18:47 EST


Quoting Rob Herring (2016-06-28 13:55:18)
> On Fri, Jun 24, 2016 at 01:12:52PM +0900, Jongsung Kim wrote:
> > There is no way to set additional flags for a DT-initialized fixed-
> > factor-clock, and it can be problematic i.e., when the clock rate
> > needs to be changed. [1][2]
> >
> > This patch introduces an optional dt-binding named "clock-flags" to
> > be used for passing any needed flags from dts.
>
> I don't think we want this in DT. If we did, the flags would need some
> documentation about what the flags mean.

Flags are specific to Linux implementation, so I agree with Rob. Better
to create a compatible string for your hardware that bakes in the flags.

Regards,
Mike

>
> Rob