Re: [PATCH 0/2] fujitsu-laptop: Debugging cleanup

From: Darren Hart
Date: Tue Jun 28 2016 - 13:50:33 EST


On Thu, Jun 23, 2016 at 08:05:35PM +0930, Jonathan Woithe wrote:
> On Thu, Jun 23, 2016 at 12:02:46PM +0200, Micha?? K??pie?? wrote:
> > vdbg_printk() was introduced by 20b9373, which is the same commit that
> > adds FUJ02E3 support, so it has been the way it is now from the start.
> > This patch series attempts to tidy things up a bit.
> >
> > drivers/platform/x86/fujitsu-laptop.c | 12 +-----------
> > 1 file changed, 1 insertion(+), 11 deletions(-)
>
> Yes, good idea. Both patches look good to me. I would like to note in
> passing that the removal of the unused defines in the second patch was in
> fact suggested as part of a broader cleanup series by Alan Jenkins an
> embarassingly long time ago. For various reasons I didn't get a chance to
> review and apply his patch series at the time. It is my aim to rectify this
> soon, but in the meantime this two patch series is good to go in. Thanks
> for the submission.
>
> Acked-by: Jonathan Woithe <jwoithe@xxxxxxxxxx>

Queued to testing for 4.8.

>
> Regards
> jonathan
>

--
Darren Hart
Intel Open Source Technology Center