Re: [PATCH 17/23] [AARCH64] ILP32: introduce syscalls that pass off_t

From: Joseph Myers
Date: Tue Jun 28 2016 - 13:13:14 EST


On Tue, 28 Jun 2016, Yury Norov wrote:

> ILP32 has 64-bit off_t, to follow modern requirements.
> But kernel clears top-halves of input registers. It means
> we have to pass corresponding arguments in a pair, like
> aarch32 does. In this patch all affected syscalls are redefined.
> Most of them are taken from arm code.

Please follow the spirit of Adhemerval's recent work. Determine the
appropriate abstractions for the architecture differences for these
syscalls, and set up unified implementations used on all architectures,
rather than increasing the number of architecture-specific variants.

> +#ifdef __ILP32__
> +/* Define this if your 32-bit syscall API requires 64-bit register
> + pairs to start with an even-number register. */
> +#define __ASSUME_ALIGNED_REGISTER_PAIRS 1
> +#endif /* __ILP32__ */

Preprocessor indentation.

--
Joseph S. Myers
joseph@xxxxxxxxxxxxxxxx