Re: [PATCH] extcon: Add support for qcom SPMI PMIC USB id detection hardware

From: Stephen Boyd
Date: Tue Jun 28 2016 - 04:47:16 EST


Quoting Roger Quadros (2016-06-27 23:36:26)
> On 27/06/16 22:30, Stephen Boyd wrote:
> >
> > The VBUS notification is done through another piece of hardware. In this
> > case it's done by the charger module. I've sent a patch for that[1].
>
> Isn't it better if ID event is handled as well in that PMIC driver instead of
> creating a separate one here?
>
> Why do you need ID to be handled outside of the PMIC driver?
> You mentioned earlier that some Qualcomm PMICs have ID detection.

Sorry I must have confused you. There are two modules in the PMIC that
are doing detection here. The charger module is detecting the VBUS event
and this misc module is detecting the ID pin. I'm not sure why they're
two different blocks, but it is what it is in the hardware.