Re: [PATCH v2 1/3] intel_pstate: Fix incorrect placement of __initdata

From: Srinivas Pandruvada
Date: Mon Jun 27 2016 - 13:17:44 EST


On Mon, 2016-06-27 at 18:07 +0800, Jisheng Zhang wrote:
> __initdata should be placed between the variable name and equal sign
> (if there is) for the variable to be placed in the intended section.
>
> Signed-off-by: Jisheng Zhang <jszhang@xxxxxxxxxxx>
> Acked-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx>
Acked-by: Srinivas Pandruvada <srinivas.pandruvada@xxxxxxxxxxxxxxx>
> ---
> Âdrivers/cpufreq/intel_pstate.c | 6 +++---
> Â1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/cpufreq/intel_pstate.c
> b/drivers/cpufreq/intel_pstate.c
> index fe9dc17..44099e9 100644
> --- a/drivers/cpufreq/intel_pstate.c
> +++ b/drivers/cpufreq/intel_pstate.c
> @@ -1574,9 +1574,9 @@ static struct cpufreq_driver
> intel_pstate_driver = {
> Â .name = "intel_pstate",
> Â};
> Â
> -static int __initdata no_load;
> -static int __initdata no_hwp;
> -static int __initdata hwp_only;
> +static int no_load __initdata;
> +static int no_hwp __initdata;
> +static int hwp_only __initdata;
> Âstatic unsigned int force_load;
> Â
> Âstatic int intel_pstate_msrs_not_valid(void)