Re: [PATCH] fujitsu-laptop: Support touchpad toggle hotkey on Skylake-based models

From: MichaÅ KÄpieÅ
Date: Mon Jun 27 2016 - 08:55:46 EST


> > Haswell-based Fujitsu laptops (Lifebook E734/E744/E754) have a touchpad
> > toggle hotkey (Fn+F4) which is handled transparently to the operating
> > system: while an ACPI notification is sent to FUJ02B1 when Fn+F4 is
> > pressed, touchpad state is properly toggled without any explicit support
> > for this operation in fujitsu-laptop.
> > :
>
> I am happy with the patch code once the one-line fix from Jan-Marek is
> included. However, given the rather non-intuitive behaviour that the patch
> is dealing with I wonder whether a short (2 line) comment in the code might
> be justified. There is otherwise no obvious reason why the touchpad button
> code must interact with the rf kill hardware.
>
> Please respin the patch with the above in mind (and inlude Jan-Marek's fix).

Will do, thanks for the review.

--
Best regards,
MichaÅ KÄpieÅ