Re: [PATCH 3/5] PM / devfreq: make exynos-bus ARM_EXYNOS_BUS_DEVFREQ tristate

From: Chanwoo Choi
Date: Sun Jun 26 2016 - 22:28:45 EST


Hi Paul,

On 2016ë 06ì 26ì 03:43, Paul Gortmaker wrote:
> The Kconfig currently controlling compilation of this code is:
>
> devfreq/Kconfig:config ARM_EXYNOS_BUS_DEVFREQ
> devfreq/Kconfig: bool "ARM EXYNOS Generic Memory Bus DEVFREQ Driver"
>
> ...meaning that it currently is not being built as a module by anyone.
>
> Rather than rip out the existing modular code, Chanwoo indicated
> that he'd rather see the driver offered as tristate.
>
> I don't have the hardware for runtime validation, so this change
> is only validated for compile and modpost.
>
> Cc: Chanwoo Choi <cw00.choi@xxxxxxxxxxx>
> Cc: MyungJoo Ham <myungjoo.ham@xxxxxxxxxxx>
> Cc: Kyungmin Park <kyungmin.park@xxxxxxxxxxx>
> Cc: Kukjin Kim <kgene@xxxxxxxxxx>
> Cc: Krzysztof Kozlowski <k.kozlowski@xxxxxxxxxxx>
> Cc: linux-pm@xxxxxxxxxxxxxxx
> Cc: linux-samsung-soc@xxxxxxxxxxxxxxx
> Signed-off-by: Paul Gortmaker <paul.gortmaker@xxxxxxxxxxxxx>
> ---
> drivers/devfreq/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/devfreq/Kconfig b/drivers/devfreq/Kconfig
> index 78dac0e9da11..a5be56ec57f2 100644
> --- a/drivers/devfreq/Kconfig
> +++ b/drivers/devfreq/Kconfig
> @@ -75,7 +75,7 @@ config DEVFREQ_GOV_PASSIVE
> comment "DEVFREQ Drivers"
>
> config ARM_EXYNOS_BUS_DEVFREQ
> - bool "ARM EXYNOS Generic Memory Bus DEVFREQ Driver"
> + tristate "ARM EXYNOS Generic Memory Bus DEVFREQ Driver"
> depends on ARCH_EXYNOS
> select DEVFREQ_GOV_SIMPLE_ONDEMAND
> select DEVFREQ_GOV_PASSIVE
>

Acked-by: Chanwoo Choi <cw00.choi@xxxxxxxxxxx>

Regards,
Chanwoo Choi