Re: [PATCH 1/2] cgroup: pids: show number of failed forks since limit reset

From: Tejun Heo
Date: Fri Jun 24 2016 - 11:31:59 EST


Hello,

On Fri, Jun 24, 2016 at 01:00:48PM +1000, Aleksa Sarai wrote:
> This allows users to dynamically adjust their limits based on how many
> failed forks happened since they last reset their limits, otherwise they
> would have to track (in a racy way) how many limit failures there were
> since the last limit change manually. In addition, we log the first
> failure since the limit was reset (which was the original semantics of
> the patchset).

Isn't that trivially achievable by reading the counter and then
calculating the diff? I don't think it matters all that much whether
the log message is printed once per cgroup or per config-change. It's
just a hint for the admin to avoid setting her off on a wild goose
chase.

Thanks.

--
tejun