Re: [PATCH 1/5] hwmon: (tmp102) Use devm_add_action to register cleanup function

[Guenter Roeck]

On 06/24/2016 07:30 AM, Guenter Roeck wrote:
> Hi Nishanth,
>
> On 06/24/2016 07:13 AM, Nishanth Menon wrote:
> > On 06/23/2016 07:28 PM, Guenter Roeck wrote:
> > > By registering a cleanup function with devm_add_action(), we can
> > > simplify the error path in the probe function and drop the remove
> > > function entirely.
> > >
> > > Signed-off-by: Guenter Roeck <linux@xxxxxxxxxxxx>
> >
> > I dont seem to have a cover letter to reply to... but anyways..
> >
> > Before: http://pastebin.ubuntu.com/17801376/
> > After all 5 patches: http://pastebin.ubuntu.com/17801824/
> >
> > Fails on beagleboard-X15 with:
> > [   36.781509] tmp102 0-0048: No cache defaults, reading back from HW
> > [   36.795940] tmp102 0-0048: unexpected config register value
> >
> > I have'nt bisected down on the specific patch in the series. Have you had a chance to test the series?
>
> Thanks for testing. Yes, I did test it. Maybe different chip revisions, or different
> initial config register values and I messed up there. Can you send me the output
> of i2cdump (word wide) ?

Also, beagleboard uses the omap i2c controller, correct ? I'll have to check
if regmap handles endianness conversion properly for controllers supporting
I2C_FUNC_I2C. If some other i2c controller is used, please let me know (or
sene me the output of i2cdetect -l). Recent kernels have a bug in regmap
which affects chips with 16-bit registers if I2C_FUNC_I2C is not supported.

Maybe I should get a beagleboard. The X15 isn't available yet, though. Do the
available boards (eg Rev C) use the same i2c controller ?

Thanks,
Guenter