Re: [PATCH 2/2] ARM: dts: at91: Modify information in LED nodes.

From: Alexandre Belloni
Date: Fri Jun 24 2016 - 09:40:31 EST


Hi,

On 24/06/2016 at 19:01:09 +0530, Raashid Muhammed wrote :
> Add power led node and rename status led node.
>

Well, I'm ok with the change but this does more:

> Signed-off-by: Raashid Muhammed <raashidmuhammed@xxxxxxxxxxx>
> Reviewed-by: Vijay Kumar B. <vijaykumar@xxxxxxxxxxxx>
> ---
> arch/arm/boot/dts/at91-sam9_l9260.dts | 13 +++++++++----
> 1 file changed, 9 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm/boot/dts/at91-sam9_l9260.dts b/arch/arm/boot/dts/at91-sam9_l9260.dts
> index be409f2..814753a 100644
> --- a/arch/arm/boot/dts/at91-sam9_l9260.dts
> +++ b/arch/arm/boot/dts/at91-sam9_l9260.dts
> @@ -106,11 +106,16 @@
> leds {
> compatible = "gpio-leds";
>
> - b0 {
> - label = "b0";
> - gpios = <&pioA 6 GPIO_ACTIVE_HIGH>;
> - linux,default-trigger = "heartbeat";
> + pwr_led {
> + label = "sam9-l9260:yellow:pwr";
> + gpios = <&pioA 9 GPIO_ACTIVE_HIGH>;
> + linux,default-trigger = "cpu0";
> };
>
> + status_led {
> + label = "sam9-l9260:green:status";
> + gpios = <&pioA 6 GPIO_ACTIVE_LOW>;
> + linux,default-trigger = "timer";

This trigger is also switched from heartbeat to timer, is this
intentional?

--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com