Re: [PATCH v1 2/3] drm: Add API for capturing frame CRCs

[Jani Nikula]

On Wed, 22 Jun 2016, Daniel Vetter <daniel@xxxxxxxx> wrote:
> On Wed, Jun 22, 2016 at 4:31 PM, Thierry Reding
> <thierry.reding@xxxxxxxxx> wrote:
>> Perhaps another way to avoid that would be to put the two files into a
>> separate directory, as in:
>>
>>         /sys/kernel/debug/dri/<minor>/crtc-<pipe>/crc/
>>         +-- control
>>         +-- data
>>
>> That's slightly on the deeply nested side, but on the other hand it
>> nicely uses the filesystem for namespacing, which is what filesystems
>> are really good at.
>
> crtc-<index>/crc/(control|data) sounds great.

Side note, we should eventually do the same for sink CRCs, but I guess
under the connectors. i915 currently has a special cased version for eDP
(named "i915_sink_crc_eDP1"...), reading the data from DPCD.

BR,
Jani.

-- 
Jani Nikula, Intel Open Source Technology Center