Re: [PATCH 1/2] perf: allow add to change event state

From: Peter Zijlstra
Date: Fri Jun 03 2016 - 17:42:39 EST


On Fri, Jun 03, 2016 at 05:03:31PM -0400, Neil Leeder wrote:
> When the platform-specific pmu->add function returns
> an error, it may have also changed the event's state.
> If so, do not override that new state.

This is inadequate; it fails to what the problem is and why this is a
good solution.