Re: [PATCH v5 1/6] qspinlock: powerpc support qspinlock

[Benjamin Herrenschmidt]

On Thu, 2016-06-02 at 17:22 +0800, Pan Xinhui wrote:
> Base code to enable qspinlock on powerpc. this patch add some #ifdef
> here and there. Although there is no paravirt related code, we can
> successfully build a qspinlock kernel after apply this patch.

This is missing the IO_SYNC stuff ... It means we'll fail to do a full
sync to order vs MMIOs.

You need to add that back in the unlock path.

> Signed-off-by: Pan Xinhui <xinhui.pan@xxxxxxxxxxxxxxxxxx>
> ---
> Âarch/powerpc/include/asm/qspinlock.hÂÂÂÂÂÂ| 26
> ++++++++++++++++++++++++++
> Âarch/powerpc/include/asm/spinlock.hÂÂÂÂÂÂÂ| 27 +++++++++++++++----
> --------
> Âarch/powerpc/include/asm/spinlock_types.h |ÂÂ4 ++++
> Âarch/powerpc/lib/locks.cÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ|ÂÂ4 ++++
> Â4 files changed, 49 insertions(+), 12 deletions(-)
> Âcreate mode 100644 arch/powerpc/include/asm/qspinlock.h
> 
> diff --git a/arch/powerpc/include/asm/qspinlock.h
> b/arch/powerpc/include/asm/qspinlock.h
> new file mode 100644
> index 0000000..fc83cd2
> --- /dev/null
> +++ b/arch/powerpc/include/asm/qspinlock.h
> @@ -0,0 +1,26 @@
> +#ifndef _ASM_POWERPC_QSPINLOCK_H
> +#define _ASM_POWERPC_QSPINLOCK_H
> +
> +#include <asm-generic/qspinlock_types.h>
> +
> +#define SPIN_THRESHOLD (1 << 15)
> +#define queued_spin_unlock queued_spin_unlock
> +
> +static inline void native_queued_spin_unlock(struct qspinlock *lock)
> +{
> +	u8 *locked = (u8 *)lock;
> +#ifdef __BIG_ENDIAN
> +	locked += 3;
> +#endif
> +	/* no load/store can be across the unlock()*/
> +	smp_store_release(locked, 0);
> +}
> +
> +static inline void queued_spin_unlock(struct qspinlock *lock)
> +{
> +	native_queued_spin_unlock(lock);
> +}
> +
> +#include <asm-generic/qspinlock.h>
> +
> +#endif /* _ASM_POWERPC_QSPINLOCK_H */
> diff --git a/arch/powerpc/include/asm/spinlock.h
> b/arch/powerpc/include/asm/spinlock.h
> index 523673d..4359ee6 100644
> --- a/arch/powerpc/include/asm/spinlock.h
> +++ b/arch/powerpc/include/asm/spinlock.h
> @@ -52,6 +52,20 @@
> Â#define SYNC_IO
> Â#endif
> Â
> +#if defined(CONFIG_PPC_SPLPAR)
> +/* We only yield to the hypervisor if we are in shared processor
> mode */
> +#define SHARED_PROCESSOR (lppaca_shared_proc(local_paca-
> >lppaca_ptr))
> +extern void __spin_yield(arch_spinlock_t *lock);
> +extern void __rw_yield(arch_rwlock_t *lock);
> +#else /* SPLPAR */
> +#define __spin_yield(x)	barrier()
> +#define __rw_yield(x)	barrier()
> +#define SHARED_PROCESSOR	0
> +#endif
> +
> +#ifdef CONFIG_QUEUED_SPINLOCKS
> +#include <asm/qspinlock.h>
> +#else
> Âstatic __always_inline int arch_spin_value_unlocked(arch_spinlock_t
> lock)
> Â{
> Â	return lock.slock == 0;
> @@ -106,18 +120,6 @@ static inline int
> arch_spin_trylock(arch_spinlock_t *lock)
> Â * held.ÂÂConveniently, we have a word in the paca that holds this
> Â * value.
> Â */
> -
> -#if defined(CONFIG_PPC_SPLPAR)
> -/* We only yield to the hypervisor if we are in shared processor
> mode */
> -#define SHARED_PROCESSOR (lppaca_shared_proc(local_paca-
> >lppaca_ptr))
> -extern void __spin_yield(arch_spinlock_t *lock);
> -extern void __rw_yield(arch_rwlock_t *lock);
> -#else /* SPLPAR */
> -#define __spin_yield(x)	barrier()
> -#define __rw_yield(x)	barrier()
> -#define SHARED_PROCESSOR	0
> -#endif
> -
> Âstatic inline void arch_spin_lock(arch_spinlock_t *lock)
> Â{
> Â	CLEAR_IO_SYNC;
> @@ -169,6 +171,7 @@ extern void arch_spin_unlock_wait(arch_spinlock_t
> *lock);
> Â	do { while (arch_spin_is_locked(lock)) cpu_relax(); } while
> (0)
> Â#endif
> Â
> +#endif /* !CONFIG_QUEUED_SPINLOCKS */
> Â/*
> Â * Read-write spinlocks, allowing multiple readers
> Â * but only one writer.
> diff --git a/arch/powerpc/include/asm/spinlock_types.h
> b/arch/powerpc/include/asm/spinlock_types.h
> index 2351adc..bd7144e 100644
> --- a/arch/powerpc/include/asm/spinlock_types.h
> +++ b/arch/powerpc/include/asm/spinlock_types.h
> @@ -5,11 +5,15 @@
> Â# error "please don't include this file directly"
> Â#endif
> Â
> +#ifdef CONFIG_QUEUED_SPINLOCKS
> +#include <asm-generic/qspinlock_types.h>
> +#else
> Âtypedef struct {
> Â	volatile unsigned int slock;
> Â} arch_spinlock_t;
> Â
> Â#define __ARCH_SPIN_LOCK_UNLOCKED	{ 0 }
> +#endif
> Â
> Âtypedef struct {
> Â	volatile signed int lock;
> diff --git a/arch/powerpc/lib/locks.c b/arch/powerpc/lib/locks.c
> index f7deebd..a9ebd71 100644
> --- a/arch/powerpc/lib/locks.c
> +++ b/arch/powerpc/lib/locks.c
> @@ -23,6 +23,7 @@
> Â#include <asm/hvcall.h>
> Â#include <asm/smp.h>
> Â
> +#ifndef CONFIG_QUEUED_SPINLOCKS
> Âvoid __spin_yield(arch_spinlock_t *lock)
> Â{
> Â	unsigned int lock_value, holder_cpu, yield_count;
> @@ -42,6 +43,7 @@ void __spin_yield(arch_spinlock_t *lock)
> Â		get_hard_smp_processor_id(holder_cpu), yield_count);
> Â}
> ÂEXPORT_SYMBOL_GPL(__spin_yield);
> +#endif
> Â
> Â/*
> Â * Waiting for a read lock or a write lock on a rwlock...
> @@ -69,6 +71,7 @@ void __rw_yield(arch_rwlock_t *rw)
> Â}
> Â#endif
> Â
> +#ifndef CONFIG_QUEUED_SPINLOCKS
> Âvoid arch_spin_unlock_wait(arch_spinlock_t *lock)
> Â{
> Â	smp_mb();
> @@ -84,3 +87,4 @@ void arch_spin_unlock_wait(arch_spinlock_t *lock)
> Â}
> Â
> ÂEXPORT_SYMBOL(arch_spin_unlock_wait);
> +#endif