Re: [PATCH 32/32] mmc: bcm2835: Import bcm2835-mmc and switch to it

From: Eric Anholt
Date: Thu Jun 02 2016 - 14:19:04 EST


Stefan Wahren <stefan.wahren@xxxxxxxx> writes:

> Hi Gerd,
>
> Am 01.06.2016 um 23:43 schrieb Gerd Hoffmann:
>> From: Eric Anholt <eric@xxxxxxxxxx>
>>
>> With this we can get wifi (brcmfmac) to probe. Without it we're stuck
>> with timeouts from sdio.c when it tries to set the bus width to 4.
>
> adding a new MMC driver to fix a wifi issue is really weird.
>
> Beside that there are already two MMC drivers (sdhci-bcm2835.c and
> sdhci-iproc.c) in the Kernel which are compatible to BCM2835. Why should
> we add two new ones?

Despite the fact that this is my commit, I don't think it should be
merged. We should figure out why sdhci-iproc.c isn't working, instead.

Attachment: signature.asc
Description: PGP signature