RE: [PATCH] x86/mce: Do not use bank 1 for APEI generated error logs.

From: Luck, Tony
Date: Tue May 31 2016 - 14:18:51 EST


> Btw, would it have any benefit of writing a "magic" value in m.bank
> to denote the error comes from APEI instead of number of banks which
> differs between generations?
>
> Something like
>
> m.bank = -1;
>
> or so?

That might be a bit more obvious than my subtle "one more than possible
on this platform" magic number.

> 255 banks will never happen anyway! (Famous last words ... :-)))

Intel is stuck at 32 unless we come up with a new mechanism and change
all the code that generates MSR numbers with "base + 4*i". There are
some virtualization MSRs allocated at what would be bank32.

-Tony