Re: [PATCH 5/5] coresight: Cleanup TMC status check

From: Mathieu Poirier
Date: Tue May 31 2016 - 14:01:28 EST


On 31 May 2016 at 05:57, Suzuki K Poulose <suzuki.poulose@xxxxxxx> wrote:
> Use the defined symbol rather than hardcoding the value to
> check whether the TMC buffer is full.
>
> Cc: Mathieu Poirier <mathieu.poirier@xxxxxxxxxx>
> Signed-off-by: Suzuki K Poulose <suzuki.poulose@xxxxxxx>
> ---
> drivers/hwtracing/coresight/coresight-tmc-etr.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hwtracing/coresight/coresight-tmc-etr.c b/drivers/hwtracing/coresight/coresight-tmc-etr.c
> index 847d1b5..b0dce93 100644
> --- a/drivers/hwtracing/coresight/coresight-tmc-etr.c
> +++ b/drivers/hwtracing/coresight/coresight-tmc-etr.c
> @@ -65,7 +65,7 @@ static void tmc_etr_dump_hw(struct tmc_drvdata *drvdata)
> val = readl_relaxed(drvdata->base + TMC_STS);
>
> /* How much memory do we still have */
> - if (val & BIT(0))
> + if (val & TMC_STS_FULL)
> drvdata->buf = drvdata->vaddr + rwp - drvdata->paddr;
> else
> drvdata->buf = drvdata->vaddr;
> --
> 1.9.1
>

Applied - thanks.
Mathieu