Re: [PATCH perf/core v9 01/16] perf-symbol: Introduce filename__readable to check readability

From: Arnaldo Carvalho de Melo
Date: Mon May 30 2016 - 12:04:55 EST


Em Mon, May 30, 2016 at 01:03:17PM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Sun, May 29, 2016 at 12:15:13AM +0900, Masami Hiramatsu escreveu:
> > Introduce filename__readable to check readability by opening
> > the file directly. Since the access(R_OK) just checks the
> > readability based on real UID/GID, it is ignored that the
> > effective UID/GID and capabilities for some special file (e.g.
> > /proc/kcore).
> > filename__readable() directly opens given file with O_RDONLY
> > so that the kernel checks it by effective UID/GID and capabilities.
>
>
> You missed the Signed-off-by line.

This this for you this time, no need to resend.

- Arnaldo