Re: [RFT][PATCH v2] regulator: max8973: Fix setting ramp delay

From: Krzysztof Kozlowski
Date: Mon May 30 2016 - 05:22:11 EST


On 05/30/2016 11:09 AM, Axel Lin wrote:
> Current code for .set_ramp_delay() rounds down the value written to
> register, while the implementation of .set_voltage_time_sel() works on
> original constraints (not rounded down).
> Fix the logic in .set_ramp_delay and also remove unused ret_val variable.
>
> Signed-off-by: Axel Lin <axel.lin@xxxxxxxxxx>
> ---
> v2: Update commit log base on Krzysztof's comment.
> drivers/regulator/max8973-regulator.c | 16 ++++++----------
> 1 file changed, 6 insertions(+), 10 deletions(-)


Reviewed-by: Krzysztof Kozlowski <k.kozlowski@xxxxxxxxxxx>

Best regards,
Krzysztof