Re: [PATCH v6 05/11] perf tools: Separate local/remote libunwind config

From: Jiri Olsa
Date: Mon May 30 2016 - 04:52:53 EST


On Sat, May 28, 2016 at 11:59:54AM +0000, He Kuang wrote:

SNIP

> diff --git a/tools/perf/config/Makefile b/tools/perf/config/Makefile
> index 6f9f566..3a304a3 100644
> --- a/tools/perf/config/Makefile
> +++ b/tools/perf/config/Makefile
> @@ -354,10 +354,24 @@ ifeq ($(ARCH),powerpc)
> endif
>
> ifndef NO_LIBUNWIND
> + have_libunwind :=
> ifneq ($(feature-libunwind), 1)
> msg := $(warning No libunwind found. Please install libunwind-dev[el] >= 1.1 and/or set LIBUNWIND_DIR);
> + NO_LOCAL_LIBUNWIND := 1
> + else
> + have_libunwind := 1
> + CFLAGS += -DHAVE_LIBUNWIND_LOCAL_SUPPORT
> + $(call detected,CONFIG_LOCAL_LIBUNWIND)
> + endif
> +
> + ifneq ($(have_libunwind), 1)
> NO_LIBUNWIND := 1
> + else
> + CFLAGS += -I$(LIBUNWIND_DIR)/include
> + LDFLAGS += -L$(LIBUNWIND_DIR)/lib

changelog says it's just switch, then why do we need to add above setup?

jirka