Re: [PATCH] pwm: don't allow duty cycle higher than period

From: Brian Norris
Date: Fri May 27 2016 - 12:50:44 EST


On Fri, May 27, 2016 at 09:39:43AM -0700, Brian Norris wrote:
> On Fri, May 27, 2016 at 06:38:14PM +0200, Boris Brezillon wrote:
> > On Fri, 27 May 2016 09:35:33 -0700
> > Brian Norris <briannorris@xxxxxxxxxxxx> wrote:
> > > On Fri, May 27, 2016 at 09:34:39AM +0200, Boris Brezillon wrote:
> > > Now that you mention it, I think you've also dropped some signed
> > > (negative value) checking in pwm_config(). I'll squash in your diff +
> > > some pwm_config() fixes.
> >
> > ->period and ->duty_cycle are unsigned now ;).
>
> Not in pwm_config(). And we don't want to implitly make thos into large

I really can't spell today... two typos in the same sentence!

> unsigned values.

Brian