Re: [PATCH] pinctrl: samsung: Suppress unbinding to prevent theoretical attacks

From: Krzysztof Kozlowski
Date: Fri May 27 2016 - 04:42:41 EST


On 05/26/2016 11:08 AM, Linus Walleij wrote:
> On Tue, May 17, 2016 at 8:02 AM, Krzysztof Kozlowski
> <k.kozlowski@xxxxxxxxxxx> wrote:
>
>> Although unbinding a pinctrl driver requires root privileges but it
>> still might be used theoretically in certain attacks (by triggering NULL
>> pointer exception or memory corruption).
>
> Patch applied with Javier's review tag.
>
> I suspect this kind of patch should be done to a few
> GPIO controller :/

Probably yes... Either the driver properly and safely handles unbind
(remove() callback) or it should be forbidden. In the same time, even if
remove() is implemented, unbinding some of the core SoC drivers is like
shooting self in the foot.

Best regards,
Krzysztof