RE: [PATCH 2/7] crypto : async implementation for sha1-mb

From: Yu, Fenghua
Date: Thu May 26 2016 - 17:25:22 EST


> From: Dey, Megha
> Sent: Thursday, May 19, 2016 5:43 PM
> To: herbert@xxxxxxxxxxxxxxxxxxx
> Cc: tim.c.chen@xxxxxxxxxxxxxxx; davem@xxxxxxxxxxxxx; linux-
> crypto@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Dey, Megha
> <megha.dey@xxxxxxxxx>; Yu, Fenghua <fenghua.yu@xxxxxxxxx>; Megha
> Dey <megha.dey@xxxxxxxxxxxxxxx>
> Subject: [PATCH 2/7] crypto : async implementation for sha1-mb
>
> From: Megha Dey <megha.dey@xxxxxxxxxxxxxxx>
>
> Herbert wants the sha1-mb algorithm to have an async implementation:
> https://lkml.org/lkml/2016/4/5/286.
> Currently, sha1-mb uses an async interface for the outer algorithm and a sync
> interface for the inner algorithm. This patch introduces a async interface for
> even the inner algorithm.
>
> Signed-off-by: Megha Dey <megha.dey@xxxxxxxxxxxxxxx>
> Signed-off-by: Tim Chen <tim.c.chen@xxxxxxxxxxxxxxx>
> ---
> arch/x86/crypto/sha-mb/sha1_mb.c | 190 ++++++++++++++++++++++------
> -----------
> crypto/ahash.c | 6 --
> crypto/mcryptd.c | 117 +++++++++++++-----------
> include/crypto/hash.h | 6 ++
> include/crypto/internal/hash.h | 8 +-
> include/crypto/mcryptd.h | 8 +-
> 6 files changed, 184 insertions(+), 151 deletions(-)
>

Hi, Herbert,

Any comment/feedback on this patch set? Is there any plan to push it to upstream?

Thanks.

-Fenghua