Re: [PATCH 2/5] asus-wmi: Create quirk for airplane_mode LED

From: Darren Hart
Date: Wed May 25 2016 - 17:24:20 EST


On Wed, May 25, 2016 at 09:13:23AM +0200, Corentin Chary wrote:
> On Mon, Feb 8, 2016 at 6:05 PM, João Paulo Rechi Vita <jprvita@xxxxxxxxx> wrote:
> > Some Asus laptops that have an "airplane mode" indicator LED, also have
> > the WMI WLAN user bit set, and the following bits in their DSDT:
> >
> > Scope (_SB)
> > {
> > (...)
> > Device (ATKD)
> > {
> > (...)
> > Method (WMNB, 3, Serialized)
> > {
> > (...)
> > If (LEqual (IIA0, 0x00010002))
> > {
> > OWGD (IIA1)
> > Return (One)
> > }
> > }
> > }
> > }
> >
> > So when asus-wmi uses ASUS_WMI_DEVID_WLAN_LED (0x00010002) to store the
> > wlan state, it drives the airplane mode indicator LED (through the call
> > to OWGD) in an inverted fashion: the LED is ON when airplane mode is OFF
> > (since wlan is ON), and vice-versa.
> >
> > This commit creates a quirk to not register a RFKill switch at all for
> > these laptops, to allow the asus-wireless driver to drive the airplane
> > mode LED correctly. It also adds a match to that quirk for the Asus
> > X555UB.
>
> This is really something that should get merged, multiple users are
> affected by this. I do not own any of these laptops, but would there
> be a way to detect this behavior instead of having static quircks ?

I believe this is all still blocked on the underlying RFKILL support. João,
correct me if I'm mistaken.

--
Darren Hart
Intel Open Source Technology Center