Re: [PATCH] batman-adv: Deinline batadv_orig_hash_find, save 9024 bytes

From: Sven Eckelmann
Date: Fri Apr 29 2016 - 17:15:43 EST


On Monday 25 April 2016 15:25:22 Denys Vlasenko wrote:
> This function compiles to 473 bytes of machine code.
> 21 callsites.
>
> text data bss dec hex filename
> 95903266 20860288 35991552 152755106 91adba2 vmlinux_before
> 95894242 20860288 35991552 152746082 91ab862 vmlinux
>
> Signed-off-by: Denys Vlasenko <dvlasenk@xxxxxxxxxx>
> CC: Marek Lindner <mareklindner@xxxxxxxxxxxxx>
> CC: Simon Wunderlich <sw@xxxxxxxxxxxxxxxxxx>
> CC: Antonio Quartulli <a@xxxxxxxxxxx>
> CC: Sven Eckelmann <sven@xxxxxxxxxxxxx>
> CC: b.a.t.m.a.n@xxxxxxxxxxxxxxxxxxx
> CC: linux-kernel@xxxxxxxxxxxxxxx
> ---
> net/batman-adv/originator.c | 29 +++++++++++++++++++++++++++++
> net/batman-adv/originator.h | 31 ++-----------------------------
> 2 files changed, 31 insertions(+), 29 deletions(-)
>

This patch should also remove following includes from originator.h:

-#include <linux/kref.h>
-#include <linux/rculist.h>
-#include <linux/rcupdate.h>
-#include <linux/stddef.h>
-#include "hash.h"

and add following includes to originator.c (please keep them in alphabetical
order):

+#include <linux/rcupdate.h>
+#include <linux/stddef.h>

Kind regards,
Sven

Attachment: signature.asc
Description: This is a digitally signed message part.