Re: [PATCH v4 07/10] x86/xsaves: Fix PTRACE frames for XSAVES

From: Dave Hansen
Date: Fri Apr 29 2016 - 16:17:09 EST


On 03/04/2016 10:12 AM, Yu-cheng Yu wrote:
> + if (boot_cpu_has(X86_FEATURE_XSAVES)) {
> + ret = copyout_from_xsaves(pos, count, kbuf, ubuf, xsave);

On a higher level, we really should stop using
"boot_cpu_has(X86_FEATURE_XSAVES)" as a proxy for "the kernel XSAVE
buffer is in the XSAVES format". I think our use of the _hardware_
CPUID bit is confusing at least the KVM folks.

We probably want a software X86_FEATURE_OS_XSAVES or something.