Re: [PATCH 19/20] md: simplify free_params for kmalloc vs vmalloc fallback

From: Mike Snitzer
Date: Thu Apr 28 2016 - 11:37:44 EST


On Thu, Apr 28 2016 at 9:24am -0400,
Michal Hocko <mhocko@xxxxxxxxxx> wrote:

> From: Michal Hocko <mhocko@xxxxxxxx>
>
> Use kvfree rather than DM_PARAMS_[KV]MALLOC specific param flags.
>
> Cc: Shaohua Li <shli@xxxxxxxxxx>
> Cc: Mikulas Patocka <mpatocka@xxxxxxxxxx>
> Cc: dm-devel@xxxxxxxxxx
> Signed-off-by: Michal Hocko <mhocko@xxxxxxxx>

Nack, seriously, this is the 3rd time this patch has been attempted.
Did you actually test the change? It'll crash very quickly, see:

https://www.redhat.com/archives/dm-devel/2016-April/msg00103.html