Re: [PATCH V5 2/6] of/slimbus: OF helper for SLIMbus

[Arnd Bergmann]

On Wednesday 27 April 2016 17:58:05 Sagar Dharia wrote:
> +#if IS_ENABLED(CONFIG_OF)
> +/* OF helpers for SLIMbus */
> +static void of_register_slim_devices(struct slim_controller *ctrl)
> +{
> +       struct device_node *node;
> 

The #ifdef seems useless here, what kind of system would not have CONFIG_OF
enabled? I'd suggest merging this into patch 1 and removing the conditional

	Arnd