Re: [PATCH 20/21] X86_64, UV: Remove Obsolete GRU MMR address translation

From: Ingo Molnar
Date: Thu Apr 28 2016 - 04:50:08 EST



* Mike Travis <travis@xxxxxxx> wrote:

> /*
> + * Send a noop message in order to deliver a cross-partition interrupt
> + * to the SSI that contains the target message queue. Normally, the
> + * interrupt is automatically delivered by hardware following mesq
> + * operations, but some error conditions require explicit delivery.
> + * The noop message will trigger delivery. Otherwise partition failures
> * could cause unrecovered errors.
> */

This is a properly structured comment.

> + /* Don't indicate to the app to resend the message, as it's */
> + /* already been successfully sent. We simply send an OK */
> + /* (rather than fail the send with MQE_UNEXPECTED_CB_ERR), */
> + /* assuming that the other side is receiving enough */
> + /* interrupts to get this message processed anyway. */

This is not...

Thanks,

Ingo