Re: [PATCH v5 1/4] printk/nmi: generic solution for safe printk in NMI

From: Russell King - ARM Linux
Date: Wed Apr 27 2016 - 05:33:46 EST


On Thu, Apr 21, 2016 at 01:48:42PM +0200, Petr Mladek wrote:
> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> index cdfa6c2b7626..259543ec6dc9 100644
> --- a/arch/arm/Kconfig
> +++ b/arch/arm/Kconfig
> @@ -66,6 +66,7 @@ config ARM
> select HAVE_KRETPROBES if (HAVE_KPROBES)
> select HAVE_MEMBLOCK
> select HAVE_MOD_ARCH_SPECIFIC
> + select HAVE_NMI
> select HAVE_OPROFILE if (HAVE_PERF_EVENTS)
> select HAVE_OPTPROBES if !THUMB2_KERNEL
> select HAVE_PERF_EVENTS
> diff --git a/arch/arm/kernel/smp.c b/arch/arm/kernel/smp.c
> index baee70267f29..df90bc59bfce 100644
> --- a/arch/arm/kernel/smp.c
> +++ b/arch/arm/kernel/smp.c
> @@ -644,9 +644,11 @@ void handle_IPI(int ipinr, struct pt_regs *regs)
> break;
>
> case IPI_CPU_BACKTRACE:
> + printk_nmi_enter();
> irq_enter();
> nmi_cpu_backtrace(regs);
> irq_exit();
> + printk_nmi_exit();
> break;
>
> default:

For the above,

Acked-by: Russell King <rmk+kernel@xxxxxxxxxxxxxxxx>

--
RMK's Patch system: http://www.arm.linux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.