Re: [RFC v2 7/8] drm/fence: add fence timeline to drm_crtc

From: Daniel Stone
Date: Wed Apr 27 2016 - 04:23:20 EST


Hi,

On 26 April 2016 at 00:33, Gustavo Padovan <gustavo@xxxxxxxxxxx> wrote:
> +static inline struct drm_crtc *fence_to_crtc(struct fence *fence)
> +{
> + if (fence->ops != &drm_crtc_fence_ops)
> + return NULL;

Since this is (currently) only used before unconditional dereferences,
maybe turn this into a BUG_ON instead of return NULL?

Cheers,
Daniel