Re: + mm-zswap-use-workqueue-to-destroy-pool.patch added to -mm tree

From: Sergey Senozhatsky
Date: Wed Apr 27 2016 - 01:38:36 EST


Hello,

On (04/26/16 16:52), akpm@xxxxxxxxxxxxxxxxxxxx wrote:
[..]
> -static void __zswap_pool_release(struct rcu_head *head)
> +static void __zswap_pool_release(struct work_struct *work)
> {
> - struct zswap_pool *pool = container_of(head, typeof(*pool), rcu_head);
> + struct zswap_pool *pool = container_of(work, typeof(*pool), work);
> +
> + synchronize_rcu();
>
> /* nobody should have been able to get a kref... */
> WARN_ON(kref_get_unless_zero(&pool->kref));
> @@ -674,7 +676,9 @@ static void __zswap_pool_empty(struct kr
> WARN_ON(pool == zswap_pool_current());
>
> list_del_rcu(&pool->list);
> - call_rcu(&pool->rcu_head, __zswap_pool_release);
> +
> + INIT_WORK(&pool->work, __zswap_pool_release);
> + schedule_work(&pool->work);
>
> spin_unlock(&zswap_pools_lock);
> }
> _
>
> Patches currently in -mm which might be from ddstreet@xxxxxxxx are
>
> mm-zpool-use-workqueue-for-zpool_destroy.patch
> mm-zswap-use-workqueue-to-destroy-pool.patch

I think only mm-zswap-use-workqueue-to-destroy-pool.patch is
needed.

-ss