Re: [PATCH] printk: make printk.synchronous param rw

From: Sergey Senozhatsky
Date: Tue Apr 26 2016 - 21:08:19 EST


Hello,

On (04/26/16 16:15), Petr Mladek wrote:
[..]
> > diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c
> > index 89f5441..9345a29 100644
> > --- a/kernel/printk/printk.c
> > +++ b/kernel/printk/printk.c
> > @@ -2757,6 +2759,13 @@ static int __init printk_late_init(void)
> > late_initcall(printk_late_init);
> >
> > #if defined CONFIG_PRINTK
> > +/*
> > + * Prevent starting printk_kthread from start_kernel()->parse_args().
> > + * It's not possible at this stage. Instead, do it via the inticall
> ^^^^^^^^
>
> s/inticall/initcall/

geez, english is hard :(


> Otherwise, it looks fine. I like the series and keep my fingers
> crossed.
>
> Reviewed-by: Petr Mladek <pmladek@xxxxxxxx>

thanks!

my system was massively Oopsing (due to kcompactd direct freepage
allocation, I suspect), OOM panicking, etc. during zsmalloc/zram
stress tests yesterday. and async printk worked fine for me. just
for note.

-ss