Re: [PATCH 14/18] prctl: make PR_SET_THP_DISABLE wait for mmap_sem killable

From: Alex Thorlton
Date: Tue Apr 26 2016 - 11:18:48 EST


On Tue, Apr 26, 2016 at 02:56:21PM +0200, Michal Hocko wrote:
> From: Michal Hocko <mhocko@xxxxxxxx>
>
> PR_SET_THP_DISABLE requires mmap_sem for write. If the waiting
> task gets killed by the oom killer it would block oom_reaper from
> asynchronous address space reclaim and reduce the chances of timely OOM
> resolving. Wait for the lock in the killable mode and return with EINTR
> if the task got killed while waiting.
>
> Cc: Alex Thorlton <athorlton@xxxxxxx>
> Acked-by: Vlastimil Babka <vbabka@xxxxxxx>
> Signed-off-by: Michal Hocko <mhocko@xxxxxxxx>

Looks good to me - I wrote that bit of code so I think this can get an:

Acked-by: Alex Thorlton <athorlton@xxxxxxx>

Thanks for Ccing me!

- Alex