Re: [PATCH] usb: ehci-platform: add reset controller number in struct ehci_platform_priv

From: Alan Stern
Date: Tue Apr 26 2016 - 10:49:55 EST


On Tue, 26 Apr 2016, Jiancheng Xue wrote:

> > If an error occurs here...
> >
> Sorry. It's really a problem. I'll modify it in v2 like below:
>
> err = reset_control_deassert(priv->rsts[rst]);
> if(err) {
> reset_control_put(priv->rsts[rst]);
> goto err_reset;
> }

Yes, that would be good. (Except for the missing ' ' between "if" and
"(".)

> Is it OK except this bug? If so, I'll send out v2 patch.

Everything else looked okay to me.

Alan Stern