Re: [PATCH V3 1/1] perf hists: clear dummy entry accumulated period

From: Arnaldo Carvalho de Melo
Date: Mon Apr 25 2016 - 19:27:01 EST


Em Mon, Apr 25, 2016 at 08:15:00PM +0200, Jiri Olsa escreveu:
> On Sun, Apr 24, 2016 at 11:28:09PM -0700, kan.liang@xxxxxxxxx wrote:
> > From: Kan Liang <kan.liang@xxxxxxxxx>
> >
> > The accumulated period for dummy entry should also be 0.
> > Otherwise, the total overhead could be overcounted.
> > [perf]$ perf record -e '{LLC-load-misses,cpu/instructions/}'
> > --call-graph=lbr ./tchain
> > [perf]$ perf report --stdio
> > # To display the perf.data header info, please use
> > --header/--header-only options.
> > #
> > #
> > # Total Lost Samples: 0
> > #
> > # Samples: 21K of event 'anon group { LLC-load-misses,
> > cpu/instructions/
> > }'
> > # Event count (approx.): 16313667937
> > #
> > # Children Self Command Shared Object
> > Symbol
> > # ................ ................ ........... ................
> > ............................
> > #
> > 4769.98% 0.01% 0.00% 0.01% tchain_edit [kernel.vmlinux]
> > [k] update_fast_timekeeper
> > 4356.18% 0.01% 0.00% 0.01% tchain_edit [kernel.vmlinux]
> > [k] trigger_load_balance
> > 3181.12% 0.01% 0.00% 0.01% tchain_edit [kernel.vmlinux]
> > [k] irq_work_tick
> > 1592.37% 0.00% 0.00% 0.00% tchain_edit [kernel.vmlinux]
> > [k] cpu_needs_another_gp
> >
> > Signed-off-by: Kan Liang <kan.liang@xxxxxxxxx>
> > ---
> >
> > Changes since V2:
> > - Use symbol_conf.cumulate_callchain check for existance of he->stat_acc
> > Changes since V1:
> > - check he->stat_acc. Because it only be available when option children is set
>
> Acked-by: Jiri Olsa <jolsa@xxxxxxxxxx>

Thanks, applied.

- Arnaldo