Re: [Xen-devel] [tip:x86/asm] x86/mm/xen: Suppress hugetlbfs in PV guests

From: David Vrabel
Date: Mon Apr 25 2016 - 08:39:45 EST


On 25/04/16 08:52, Thomas Gleixner wrote:
> On Mon, 25 Apr 2016, Jan Beulich wrote:
>>>>> On 22.04.16 at 20:03, <hpa@xxxxxxxxx> wrote:
>>>> +#define hugepages_supported() cpu_has_pse
>>>>
>>>
>>> Please don't use the cpu_has_* macros anymore, they are going away soon.
>>>
>>> In this case it should be static_cpu_has(X86_FEATURE_PSE).
>>
>> I can certainly do that, but this
>> - will (mildly) harm backportability
>> - imo should have been requested much earlier (when the patch was
>> still under discussion)
>
> It's requested now as cpu_has_* is going away. So instead of making silly
> arguments you should have sent a delta patch fixing this.

Ingo fixed this up in the x86/asm branch[1] so I assumed this patch
didn't need updating.

David

[1]
https://git.kernel.org/cgit/linux/kernel/git/tip/tip.git/commit/?h=x86/asm&id=b2eafe890d4a09bfa63ab31ff018d7d6bb8cfefc