Re: [PATCH 5/7] soc/tegra: pmc: Register sub-devices of PMC

From: Stephen Warren
Date: Fri Apr 15 2016 - 12:31:30 EST


On 04/12/2016 08:56 AM, Laxman Dewangan wrote:
Register sub devices of the PMC to support multiple functionalities
of PMC.
The sub devices are the subnode of PMC DT node with containing the
compatible string of sub devices as follows:

pmc@0,7000e400 {
pmc-pad-control {
compatible = "nvidia,tegra210-io-pad";
::
};
};

In this pmc-pad-control is the sub device of PMC and the device
compatibility is nvidia,tegra210-io-pad.

Since I don't think anyone has mentioned this point on the public lists, I'll echo the earlier internal discussion on this patch. I think the PMC driver should handle this all entirely internally. The PMC HW module doesn't have well-defined sub-modules, and hence we shouldn't represent sub-modules in DT. DT should represent HW structure, not Linux SW structure.