Re: [PATCH v4 2/7] dt-bindings: Add bindings for phy-da8xx-usb

From: Sergei Shtylyov
Date: Fri Apr 15 2016 - 06:52:36 EST


Hello.

On 4/14/2016 9:35 PM, David Lechner wrote:

Device tree binding for new phy-da8xx-usb driver.

Signed-off-by: David Lechner <david@xxxxxxxxxxxxxx>
Acked-by: Rob Herring <robh@xxxxxxxxxx>
---

v4 changes:

* swapped order of usb20 and usb11 to be in logical order of reg address.

.../devicetree/bindings/phy/phy-da8xx-usb.txt | 40 ++++++++++++++++++++++
1 file changed, 40 insertions(+)
create mode 100644 Documentation/devicetree/bindings/phy/phy-da8xx-usb.txt

diff --git a/Documentation/devicetree/bindings/phy/phy-da8xx-usb.txt b/Documentation/devicetree/bindings/phy/phy-da8xx-usb.txt
new file mode 100644
index 0000000..bead185
--- /dev/null
+++ b/Documentation/devicetree/bindings/phy/phy-da8xx-usb.txt
@@ -0,0 +1,40 @@
+TI DaVinci DA8xx USB PHY

DA8xx is not DaVinci, please omit this.

+
+Required properties:
+ - compatible: must be "ti,da830-usbphy".
+ - #phy-cells: must be 1.
+
+This device controls the PHY for both the USB 1.1 OHCI and USB 2.0 OTG
+controllers on DA8xx SoCs. Consumers of this device should use index 0 for
+the USB 2.0 phy device and index 1 for the USB 1.1 phy device.

Not indices 2 and 1 already?

+It also requires a "syscon" node with compatible = "ti,da830-cfgchip", "syscon"
+to access the CFGCHIP2 register.
+
+Example:
+
+ cfgchip: cfgchip@1417c {
+ compatible = "ti,da830-cfgchip", "syscon";
+ reg = <0x1417c 0x14>;
+ };
+
+ usbphy: usbphy {

Name it "usb-phy" please, consistent to what ePAPR has mandated for Ethernet PHYs.

[...]

MBR, Sergei