Re: [PATCH] staging: fsl-mc: bus: Drop warning

From: Matthias Brugger
Date: Fri Apr 15 2016 - 06:44:05 EST




On 15/04/16 00:57, Stuart Yoder wrote:


-----Original Message-----
From: Matthias Brugger [mailto:mbrugger@xxxxxxxx]
Sent: Thursday, April 14, 2016 4:24 PM
To: German.Rivera@xxxxxxxxxxxxx; gregkh@xxxxxxxxxxxxxxxxxxx
Cc: Stuart Yoder <stuart.yoder@xxxxxxx>; Scott Wood <scott.wood@xxxxxxx>; agraf@xxxxxxx; linux-
kernel@xxxxxxxxxxxxxxx; devel@xxxxxxxxxxxxxxxxxxxx; mbrugger@xxxxxxxx
Subject: [PATCH] staging: fsl-mc: bus: Drop warning

When updating the irq_chip and msi_domain_ops, the code checkes for
already present functions.
When more then one ITS controller are present in the system,
irq_chip and msi_domain_ops got already set and a warning is invoked.

How can this situation happen? And what do you mean by
multiple ITS controllers? ...multiple instances of the GIC ITS
on an SoC?


Yes, there are two arm,gic-v3-its defined in the FDT.

~ # ll /proc/device-tree/interrupt-controller@8010\,00000000/
total 0
-r--r--r-- 1 root root 4 Apr 15 12:31 #address-cells
-r--r--r-- 1 root root 11 Apr 15 12:31 compatible
drwxr-xr-x 2 root root 0 Apr 15 12:31 gic-its@8010,00020000
drwxr-xr-x 2 root root 0 Apr 15 12:31 gic-its@9010,00020000
-r--r--r-- 1 root root 4 Apr 15 12:31 #interrupt-cells
-r--r--r-- 1 root root 0 Apr 15 12:31 interrupt-controller
-r--r--r-- 1 root root 12 Apr 15 12:31 interrupts
-r--r--r-- 1 root root 4 Apr 15 12:31 linux,phandle
-r--r--r-- 1 root root 21 Apr 15 12:31 name
-r--r--r-- 1 root root 4 Apr 15 12:31 phandle
-r--r--r-- 1 root root 0 Apr 15 12:31 ranges
-r--r--r-- 1 root root 4 Apr 15 12:31 #redistributor-regions
-r--r--r-- 1 root root 48 Apr 15 12:31 reg
-r--r--r-- 1 root root 4 Apr 15 12:31 #size-cells

Regards,
Matthias