Re: [PATCH v1 3/3] nvmem: core: fix regmap accessor usage

From: Srinivas Kandagatla
Date: Thu Apr 14 2016 - 12:48:44 EST




On 14/04/16 16:18, Mark Brown wrote:
On Thu, Apr 14, 2016 at 01:35:03PM +0100, Srinivas Kandagatla wrote:

I totally agree that there is an abstraction failure here in both sides. It
should be fixed. moving to using bulk apis would solve the nvmem problem for
now. But for long term, using regmap should be totally removed from nvmem
and directly use the reg read/write callbacks from nvmem providers, This
would be much robust solution. This was indeed Maxime's first proposal. I
will try to fix it up and see how it looks without regmap.

OK, so just replacing all the _raw_ calls with _bulk_ for now? If
you're doing that watch out for the fact that the reads come back native
endian which might upset things.
Yep, that would confuse users. I think its better I do a long term solution of regmap replacement with callbacks before someone else starts reporting issues.

--srini