Re: [PATCH v1 1/3] regmap: add regmap_can_raw_read() api

From: Mark Brown
Date: Thu Apr 14 2016 - 01:58:31 EST


On Wed, Apr 13, 2016 at 06:39:12PM +0100, Srinivas Kandagatla wrote:
> This patch adds regmap_can_raw_read() api so that users like nvmem can
> check if the regmap is capable of doing a raw accessors. This can also
> be used by other infrastructures like nvmem which are based on regmap.

This seems tasteless. If the driver is using raw I/O it needs to know
exactly what device it is working with, it shouldn't need to ask the
core about the properties of the device. If it does that's a sign that
there's an abstraction problem somewhere along the line. Most likely
the driver should be using bulk I/O instead.

Attachment: signature.asc
Description: PGP signature