Re: [Xen-devel] [PATCH v4 04/14] x86/rtc: replace paravirt rtc check with platform legacy quirk

From: Luis R. Rodriguez
Date: Wed Apr 13 2016 - 19:09:03 EST


On Thu, Apr 7, 2016 at 2:42 AM, David Vrabel <david.vrabel@xxxxxxxxxx> wrote:
> On 07/04/16 01:06, Luis R. Rodriguez wrote:
>> We have 4 types of x86 platforms that disable RTC:
>>
>> * Intel MID
>> * Lguest - uses paravirt
>> * Xen dom-U - uses paravirt
>> * x86 on legacy systems annotated with an ACPI legacy flag
>>
>> We can consolidate all of these into a platform specific legacy
>> quirk set early in boot through i386_start_kernel() and through
>> x86_64_start_reservations(). This deals with the RTC quirks which
>> we can rely on through the hardware subarch, the ACPI check can
>> be dealt with separately.
>
> Xen parts:
>
> Reviewed-by: David Vrabel <david.vrabel@xxxxxxxxxx>

So for instance, I dropped this Reviewed-by given that after this
someone pointed out dom0 as an issue and then I addressed that. Hope
to get a Reviewed-by or Acked-by for v6 then, which will also have the
added __init on xen_dom0_set_legacy_features() as requested by
Juergen.

Luis