Re: [PATCH v2 1/5] ARM: STi: stih407-family: Add nodes for Mailbox

From: Olof Johansson
Date: Wed Apr 13 2016 - 17:58:16 EST


Hi,

On Wed, Mar 23, 2016 at 7:43 AM, Lee Jones <lee.jones@xxxxxxxxxx> wrote:
> This patch supplies the Mailbox Controller nodes. In order to
> request channels, these nodes will be referenced by Mailbox
> Client nodes.
>
> Signed-off-by: Lee Jones <lee.jones@xxxxxxxxxx>
> ---
> arch/arm/boot/dts/stih407-family.dtsi | 33 +++++++++++++++++++++++++++++++++
> 1 file changed, 33 insertions(+)
>
> diff --git a/arch/arm/boot/dts/stih407-family.dtsi b/arch/arm/boot/dts/stih407-family.dtsi
> index 81f8121..e6e34b4 100644
> --- a/arch/arm/boot/dts/stih407-family.dtsi
> +++ b/arch/arm/boot/dts/stih407-family.dtsi
> @@ -694,5 +694,38 @@
> clocks = <&clk_sysin>;
> status = "okay";
> };
> +
> + mailbox0: mailbox@0 {

This isn't the right unit-id here. It should be @8f000000. Same for
the other two.


-Olof