Re: [PATCH] device-tree: nexus7-flo: Remove power gpio key entry and use pmic8xxx-pwrkey

[John Stultz]

On Wed, Apr 13, 2016 at 10:24 AM, Sudeep Holla <sudeep.holla@xxxxxxx> wrote:
>
>
> On 13/04/16 18:16, John Stultz wrote:
>>
>> Since the pmic8xxx-pwrkey driver is already supported in the
>> qcom-apq8064.dtsi, and the pmic8xxx-pwrkey supports logic to
>> configure proper device shutdown when ps_hold goes low, it is
>> better to use that driver then a generic gpio button.
>>
>> Thus this patch remove the gpio power key entry here, so we
>> don't get double input events from having two drivers enabled.
>>
>> The one gotcha with the pmic8xxx-pwrkey is it has a fairly
>> long debounce delay, which we shorten here to make the button
>> behave as expected.
>>
>> Cc: Rob Herring <robh+dt@xxxxxxxxxx>
>> Cc: Arnd Bergmann <arnd.bergmann@xxxxxxxxxx>
>> Cc: Pawel Moll <pawel.moll@xxxxxxx>
>> Cc: Mark Rutland <mark.rutland@xxxxxxx>
>> Cc: Ian Campbell <ijc+devicetree@xxxxxxxxxxxxxx>
>> Cc: Kumar Gala <galak@xxxxxxxxxxxxxx>
>> Cc: Andy Gross <agross@xxxxxxxxxxxxxx>
>> Cc: Vinay Simha BN <simhavcs@xxxxxxxxx>
>> Cc: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx>
>> Cc: Stephen Boyd <stephen.boyd@xxxxxxxxxx>
>> Cc: linux-arm-msm@xxxxxxxxxxxxxxx
>> Cc: devicetree@xxxxxxxxxxxxxxx
>> Signed-off-by: John Stultz <john.stultz@xxxxxxxxxx>
>> ---
>>   arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dts | 15 +++++++++------
>>   1 file changed, 9 insertions(+), 6 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dts
>> b/arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dts
>> index c535b3f..7ac1c65 100644
>> --- a/arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dts
>> +++ b/arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dts
>> @@ -29,12 +29,6 @@
>>
>>         gpio-keys {
>>                 compatible = "gpio-keys";
>> -               power {
>> -                       label = "Power";
>> -                       gpios = <&tlmm_pinmux 26 GPIO_ACTIVE_LOW>;
>> -                       linux,code = <KEY_POWER>;
>> -                       gpio-key,wakeup;
>
>
> You are dropping wakeup with this change. Is that intentional ?
>
> If not, while you are at this, replace it with "wakeup-source"
> which is standard binding.

Thanks for catching this. Its not intentional, but I don't have
suspend/resume working yet on the n7 so I've never really tested it.

I'll add wakeup-source to the pwrkey entry for the next version.

thanks
-john