Re: [PATCH 4/5] cpufreq: Loongson1: Use devm_kzalloc() instead of global structure

From: Viresh Kumar
Date: Tue Apr 12 2016 - 01:20:24 EST


On 11-04-16, 19:55, Keguang Zhang wrote:
> From: Kelvin Cheung <keguang.zhang@xxxxxxxxx>
>
> This patch uses devm_kzalloc() instead of global structure.
>

Why are you doing this? The commit log should contain that.

> Signed-off-by: Kelvin Cheung <keguang.zhang@xxxxxxxxx>
> ---
> drivers/cpufreq/loongson1-cpufreq.c | 63 ++++++++++++++++++++-----------------
> 1 file changed, 35 insertions(+), 28 deletions(-)

I don't have any issues with you doing this, but I don't think that's
necessary to do.

Acked-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx>

--
viresh