Re: [PATCH] drivers/usb/gadget/udc/r8a66597-udc.c: Deinline pipe_change, save 2176 bytes

From: Felipe Balbi
Date: Mon Apr 11 2016 - 04:28:07 EST



Hi again,

Felipe Balbi <felipe.balbi@xxxxxxxxxxxxxxx> writes:
> Denys Vlasenko <dvlasenk@xxxxxxxxxx> writes:
>> This function compiles to 298 bytes of machine code, has ~10 callsites.
>
> fair enough
>
>> This is a USB 2.0 device, USB 2.0 is limited to 35 MB/s, so should be
>
> it's not limited to 35MB/sec, sorry. USB 2.0 has a theoretical maximum
> of 60MB/sec. But 44MB/sec is what people consider 'possible'. I've
> gotten to 41MB/sec with g_mas_storage gadget.

also, you need to break you commit log lines at 72 characters. Please,
fix and resend

--
balbi

Attachment: signature.asc
Description: PGP signature