Re: [PATCH 4/4] irqchip: bcm2836: Use a more generic memory barrier call

From: Eric Anholt
Date: Fri Apr 08 2016 - 14:20:45 EST


Stephen Warren <swarren@xxxxxxxxxxxxx> writes:

> On 04/04/2016 09:44 PM, Eric Anholt wrote:
>> dsb() requires an argument on arm64, so we needed to add "sy".
>> Instead, take this opportunity to switch to the same smp_wmb() call
>> that gic uses for its IPIs. This is a less strong barrier than we
>> were doing before (dmb(ishst) compared to dsb(sy)), but it seems to be
>> the correct one.
>
> I assume all MMIO is part of the ish domain?
>
> If so, the series,
> Acked-by: Stephen Warren <swarren@xxxxxxxxxxxxx>

I don't know if this barrier implies ordering all the way out to AXI on
this HW, but I don't think that's a requirement of this function.

Attachment: signature.asc
Description: PGP signature